[Users] checkhack-zimbra-preferences shell escape issues

[Barry De Graaff]

Yeah, I moved it off the README, but left it in the repo, for anyone who wants to 
take it and work on it. 

I will go with https://github.com/Zimbra-Community/zimbra-tools/blob/master/cbpolicyd.sh 
for this.

Kind regards, 

Barry de Graaff
Zeta Alliance Founder
www.zetalliance.org

Skype: barrydegraaff.tk
Fingerprint: 9e0e165f06b365ee1e47683e20f37303c20703f8

----- Original Message -----
From: "Guy CARRÉ" <guycarre at free.fr>
To: "Keith McDermott" <keithmcd at purdue.edu>
Cc: "Barry De Graaff" <barrydg at zetalliance.org>, users at lists.zetalliance.org, devel at lists.zetalliance.org
Sent: Tuesday, June 7, 2016 3:35:56 PM
Subject: Re: [Users] checkhack-zimbra-preferences shell escape issues

Hello, 

as it seems that the script is very old, I would advice to upgrade it by using Bash best practises, even if it is KSH which is call. 
Command like : 
this command_1=`hostname -f` 
for example has to be changed into 
command_1=$(hostname -f) 
same thing with variable : 
VAR_1=bob 
should be used like this : 
${VAR_1} 
and some people use over quote technic too. 

Regards, 


___________________________________ 
/ \ 
/-------------------------------------\ 
| Guy CARRÉ | 
| ************* | 
| PostMaster - WikiMaster - SysAdmin | 
| | 
| "Free Your Mind. Think Open Source" | 
| april.org | 
| | 
|_____________________________________| 


De: "Keith McDermott" <keithmcd at purdue.edu> 
À: "Barry De Graaff" <barrydg at zetalliance.org>, users at lists.zetalliance.org, devel at lists.zetalliance.org 
Envoyé: Mardi 7 Juin 2016 14:32:39 
Objet: Re: [Users] checkhack-zimbra-preferences shell escape issues 



Hi Barry, 

I can't remember if it was noted on Git or not, but this was written for ZCS6. We never had issues like this happen in our usage of the script for the past 5-6 years. There would be an odd thing very rarely that would cause key/pairs to get messed up, but it always created one file per user. 

Perhaps something's changed in some of the commands that are being ran since ZCS6? 

Files should be created such as: 

/tmp/zimbra-preferences-scores/2016-06-16/keithmcd 

-keith 



Keith McDermott
Messaging Systems Administrator
ITIS, ITaP
Purdue University

E-mail: keithmcd at purdue.edu Address:155 S. Grant Street
        West Lafayette, IN 47907
        
"The road to wisdom, well, it's plain and simple to express,
 Err and err and err again, but less and less and less."
 - Piet Hein 
On 6/7/16 00:49, Barry De Graaff wrote: